Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn if user action is not set in new reviewer #17588

Merged
merged 1 commit into from
Dec 10, 2024
Merged

warn if user action is not set in new reviewer #17588

merged 1 commit into from
Dec 10, 2024
+15 −0

Conversation

MorenoTropical
Copy link
Contributor

Purpose / Description

I noticed that I didn't add this to the new reviewer in my earlier PR

Fixes

Approach

Did the same of #17235

How Has This Been Tested?

a.mp4

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

BrayanDSO
BrayanDSO approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thanks

@BrayanDSO BrayanDSO added the Needs Second Approval Has one approval, one more approval to merge label Dec 10, 2024
@david-allison david-allison added this pull request to the merge queue Dec 10, 2024
Merged via the queue into ankidroid:main with commit 34d42da Dec 10, 2024
12 checks passed
@github-actions github-actions bot removed the Needs Second Approval Has one approval, one more approval to merge label Dec 10, 2024
@github-actions github-actions bot added this to the 2.21 release milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrayanDSO BrayanDSO BrayanDSO approved these changes

@david-allison david-allison david-allison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.21 release
Development

Successfully merging this pull request may close these issues.

[BUG]: "User Action 1" event is not functioning as expected
3 participants
@MorenoTropical @david-allison @BrayanDSO